gitproxy/RTLPlayground
1
0
Fork 0
mirror of https://github.com/logicog/RTLPlayground.git synced 2026-09-02 15:02:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

stp: drop the comment on the CPU tag flags

Browse Source 
Worth keeping out of the code but on record: RTL_TAG_KEEP is deliberately
not set here. On an LLC/802.3 frame the ASIC drops the frame outright with
that flag, while on ethertype frames such as LACP it works fine.
This commit is contained in:
d00f
2026-08-18 23:30:52 +02:00
parent 3cd9131795
commit 9df9eece3f
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rtl837x_stp.c
-6
View File
@@ -337,12 +337,6 @@ void stp_cnf_send(uint8_t port) __reentrant
STP_O->rtl_tag.tag = HTONS(RTL_FRAME_TAG_ID);
STP_O->rtl_tag.version = RTL_FRAME_TAG_VERSION;
STP_O->rtl_tag.reason = 0x00;
/* Through HTONS like every tag field: raw 0x0020 lands on the wire as
* 0x2000 (EFID), the ASIC fails to parse the tag and floods the frame
* with the 0x8899 header still on it (same bug class as LACP had).
* NOTE: no RTL_TAG_KEEP here - hardware-verified that KEEP on an
* LLC/802.3 (length-field) frame makes the ASIC drop it entirely,
* while the same flag works fine on ethertype frames (LACP). */
STP_O->rtl_tag.flags = HTONS(RTL_TAG_LEARN_DIS);
STP_O->rtl_tag.pmask = HTONS(((uint16_t)1) << port);