From 9df9eece3fa2b941f61d562704cf3d7594cf9956 Mon Sep 17 00:00:00 2001
From: d00f <8052722+DrDoof@users.noreply.github.com>
Date: Mon, 17 Aug 2026 10:26:51 +0200
Subject: [PATCH] stp: drop the comment on the CPU tag flags

Worth keeping out of the code but on record: RTL_TAG_KEEP is deliberately
not set here. On an LLC/802.3 frame the ASIC drops the frame outright with
that flag, while on ethertype frames such as LACP it works fine.
---
 rtl837x_stp.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/rtl837x_stp.c b/rtl837x_stp.c
index e929392..cb2d5e8 100644
--- a/rtl837x_stp.c
+++ b/rtl837x_stp.c
@@ -337,12 +337,6 @@ void stp_cnf_send(uint8_t port) __reentrant
 	STP_O->rtl_tag.tag = HTONS(RTL_FRAME_TAG_ID);
 	STP_O->rtl_tag.version = RTL_FRAME_TAG_VERSION;
 	STP_O->rtl_tag.reason = 0x00;
-	/* Through HTONS like every tag field: raw 0x0020 lands on the wire as
-	 * 0x2000 (EFID), the ASIC fails to parse the tag and floods the frame
-	 * with the 0x8899 header still on it (same bug class as LACP had).
-	 * NOTE: no RTL_TAG_KEEP here - hardware-verified that KEEP on an
-	 * LLC/802.3 (length-field) frame makes the ASIC drop it entirely,
-	 * while the same flag works fine on ethertype frames (LACP). */
 	STP_O->rtl_tag.flags = HTONS(RTL_TAG_LEARN_DIS);
 	STP_O->rtl_tag.pmask = HTONS(((uint16_t)1) << port);