mirror of
https://github.com/logicog/RTLPlayground.git
synced 2026-10-29 17:54:14 +08:00
DrDoof
6e2701bc8c
The receive interrupt was wired up but never used: EX1 was enabled, the
handler re-enabled itself and did nothing, and the mask bit for it in the
NIC stayed clear, so idle() read the receive buffer register on every
pass to find out whether a packet had arrived, and slept until the next
tick when none had. A packet that arrived during that sleep waited for
the tick: 2.2 ms on average, 5 ms at worst, for every frame the CPU
handles.
Now the handler latches rx_irq and masks itself, and idle() sleeps
unless a receive, a link change, a console command or the tick is
pending. On rx_irq the loop drains the buffer, clears the status bit and
re-enables EX1, in that order: the NIC holds the line as long as the
status bit is set, and the bit does not clear while the buffer still
holds a frame, so a frame that lands between the last read and EX1 = 1
raises the interrupt again rather than getting lost. The other order,
clearing before draining, left the line asserted and produced an
interrupt on every pass. The mask is written after nic_setup(), which
resets it.
Measured on an RTL8373 board with the same counters in both images,
clocked by the tick counter, traffic from a host behind an LACP trunk:
```
polling interrupt
idle, register ops/s 788 79
25 pps, RTT avg/max 2.19/4.96 0.44/0.75 ms
500 pps, RTT avg/max 2.78/5.06 0.39/5.40 ms
500 pps, loss 0.08% 0.08%
```
The handler compiles to clr EX1 / setb rx_irq / reti.
The timer interrupt now raises a tick flag too, so idle() no longer works
out TICKS_DUE twice per pass, and cmd_available moves from xdata to a
bit. The four wake-up flags sit in the low bits of one byte at 0x20, so
the sleep test is a single read of that byte. tx_buf_empty deliberately
stays out: it is 1 when there is nothing to do, so including it would
keep the sleep test from ever firing.
48 lines
1.4 KiB
C
48 lines
1.4 KiB
C
#ifndef _CMD_PARSER_H_
|
|
#define _CMD_PARSER_H_
|
|
|
|
#include <stdint.h>
|
|
|
|
#include "rtl837x_common.h"
|
|
|
|
extern __xdata uint8_t cmd_buffer[CMD_BUF_SIZE];
|
|
extern __bit __at(0x03) cmd_available;
|
|
extern __xdata uint8_t err_status;
|
|
|
|
/* Health instrumentation, built with HEALTH=1. Without it the hooks below
|
|
* compile to nothing and the "health" command does not exist. */
|
|
#ifdef HEALTH
|
|
/* Phase ids, in main-loop order */
|
|
#define HEALTH_PH_LINK 0
|
|
#define HEALTH_PH_SFP 1
|
|
#define HEALTH_PH_RX 2
|
|
#define HEALTH_PH_TX 3
|
|
#define HEALTH_PH_STP 4
|
|
#define HEALTH_PH_CMD 5
|
|
#define HEALTH_PHASES 6
|
|
|
|
extern __xdata uint16_t health_rx_frames;
|
|
#define health_rx_frame() health_rx_frames++
|
|
|
|
void health_loop_start(void) __banked; /* once per idle() pass, resets the phase baseline */
|
|
void health_phase(uint8_t id) __banked; /* after each phase; accounts ticks since last checkpoint */
|
|
void health_stack_paint(void) __banked; /* paint the unused stack area once at boot */
|
|
void health_show(void) __banked; /* "health" CLI dump */
|
|
#else
|
|
#define health_rx_frame()
|
|
#define health_loop_start()
|
|
#define health_phase(id)
|
|
#define health_stack_paint()
|
|
#endif
|
|
|
|
void cmd_tokenize(void) __banked;
|
|
void cmd_parser(void) __banked;
|
|
void execute_config(void) __banked;
|
|
void execute_commands(__xdata uint8_t *p) __banked;
|
|
void print_ip(__xdata uint8_t *ptr) __banked;
|
|
void print_mac(__xdata uint8_t *ptr) __banked;
|
|
void print_sw_version(void) __banked;
|
|
void clear_command_history(void) __banked;
|
|
|
|
#endif
|