mirror of
https://github.com/logicog/RTLPlayground.git
synced 2026-10-29 17:54:14 +08:00
d00f
38b8e38c04
The port table skipped every SFP port outright, so on a SWTGW218AS the uplink simply was not there. Of the seven columns only Set Speed is meaningless for a module: the name, the link speed and the devices behind the port all are worth showing, and the name in particular was accepted on another page and then never displayed anywhere. The MTU table further down the same page has always drawn the port, so the page disagreed with itself. Give an SFP port its row and leave the three control cells empty. Whether speed and disable should work for a module is a separate question and untested, so this does not offer a button for it. The link state was read one port too far. main.js fills pState by portNum - 1, updatePortTable() reads pState[i-1], and createPortTable() read pState[i], so every row started out showing the next port's link speed until the first refresh corrected it. On the last copper port that meant showing the uplink's speed. Feeding the real status.json of a nine port switch through both versions: expected 7 7 7 1 7 1 7 7 6 before 7 7 1 7 1 7 7 6 after 7 7 7 1 7 1 7 7 6 Dropping the skip also removes a trap rather than papering over it. updatePortTable() addresses rows as tbl.rows[i], which only lined up with port i because the SFP port happens to be last on this board. With a module in the middle every row after it would have been off by one.
