mirror of
https://github.com/logicog/RTLPlayground.git
synced 2026-09-02 15:02:51 +08:00
d00f
5a6b854c5d
stp_dbridge, stp_dpid and stp_dcost were declared and read by the status page, but nothing ever wrote them, so they stayed zero for the life of the firmware. The page's validity test then always failed, and the Designated Bridge, Designated Port ID and Designated Cost columns reported our own values on every port, including the root port where the answer is the upstream neighbour. The three arrays reserved 140 bytes of xdata and never used any of it. They are filled now, right after the loop check, so a frame that came back from one of our own ports is not mistaken for a neighbour. The validity test moves from the last byte of the stored MAC to the stored Port ID. A Port ID is 1-based on the wire and cannot be zero, while a neighbour whose MAC happens to end in 0x00 would have failed the old test. The root path cost byte swap happens once now, and the root port branch reuses the value instead of repeating the shifts. BANK2 grows 148 bytes, BANK1 loses 9, and xdata does not move.