From d5fdaf28e827853eb99b9bc990fa3b424a903aa4 Mon Sep 17 00:00:00 2001
From: diijkstra <16804536+diijkstra@users.noreply.github.com>
Date: Fri, 13 Mar 2026 21:43:22 +0100
Subject: [PATCH] Light description for led-set

Very light description for port_led_set and led_sets, which was
helpfull when bringing up the trendnet device.
---
 machine.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/machine.h b/machine.h
index 1c894df..a5f1952 100644
--- a/machine.h
+++ b/machine.h
@@ -49,7 +49,9 @@ struct sfp_port
 typedef struct machine {
 	char machine_name[30];
 	uint8_t isRTL8373;
+	// Lowest logical port number
 	uint8_t min_port;
+	// Highest logical port number
 	uint8_t max_port;
 	uint8_t n_sfp;
 	uint8_t log_to_phys_port[9];
@@ -59,7 +61,12 @@ typedef struct machine {
 	struct sfp_port sfp_port[2];
 	uint8_t reset_pin;
 	struct high_leds high_leds;
+	// Defines which led-set (0-3) will be used for given logical port
+	// led-set is physical group of LEDs that can be configured to show different port status combinations (see port_led_set below)
 	uint8_t port_led_set[9];
+	// Defines led-set configuration, applied to all ports using particular led-set
+	// Each led-set can have 4 different hardware LED configurations. Which one should be used, depends how LED is wired on the board
+	// See stock RTL837X_REG_LED3_2_SETx and RTL837X_REG_LED1_0_SETx registers for reference configuration
 	uint32_t led_sets[4][4];
 	uint8_t led_mux_custom;
 	uint8_t led_mux[28];