From c7fb354f08a5911f79276bcd86c2a2369c53431d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20van=20Dorst?= Date: Fri, 17 Apr 2026 23:07:39 +0200 Subject: [PATCH] parse_sds{get,set}() and parse_phy{get,set}() make use of cmd_words_len --- cmd_parser.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd_parser.c b/cmd_parser.c index 57ef402..f239cba 100644 --- a/cmd_parser.c +++ b/cmd_parser.c @@ -820,7 +820,7 @@ void parse_sdsget(void) { __xdata uint8_t sds_id, page, reg, hex_size; - if (cmd_words_b[1] < 0 || cmd_words_b[2] < 0 || cmd_words_b[3] < 0) { + if (cmd_words_len != 4) { goto err; } @@ -864,7 +864,7 @@ void parse_sdsset(void) __xdata uint8_t sds_id, page, reg, hex_size; __xdata uint16_t val; - if (cmd_words_b[1] < 0 || cmd_words_b[2] < 0 || cmd_words_b[3] < 0 || cmd_words_b[4] < 0) { + if (cmd_words_len != 5) { goto err; } @@ -919,7 +919,7 @@ void parse_phyget(void) __xdata uint8_t phy_id, dev_id, hex_size; __xdata uint16_t reg; - if (cmd_words_b[1] < 0 || cmd_words_b[2] < 0 || cmd_words_b[3] < 0) { + if (cmd_words_len != 4) { goto err; } @@ -965,7 +965,7 @@ void parse_physet(void) __xdata uint8_t phy_id, dev_id, hex_size; __xdata uint16_t reg, val; - if (cmd_words_b[1] < 0 || cmd_words_b[2] < 0 || cmd_words_b[3] < 0 || cmd_words_b[4] < 0) { + if (cmd_words_len != 5) { goto err; }