From c46261e0529de736e0ded96245c477196451b0f0 Mon Sep 17 00:00:00 2001 From: Rob Emery Date: Sat, 17 Oct 2026 20:09:33 +0100 Subject: [PATCH] Using PVID=0 for the situation where the port is only in tagged membership. This was tested on HI_K0801WS and it appears to not have any negative side-effects --- cmd_parser.c | 4 ++-- html/app.js | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/cmd_parser.c b/cmd_parser.c index ab3a5894..c5aa42ad 100644 --- a/cmd_parser.c +++ b/cmd_parser.c @@ -2011,10 +2011,10 @@ void cmd_parser(void) __banked cmd_error("lacp (show | off); a group starts LACP with: lag <1-4> lacp ...\n"); } else if (cmd_compare(0, "pvid")) { if (cmd_words_len == 3 && cmd_parse_port_separator(cmd_words_b[1]) != 0 - && atoi_short(cmd_words_b[2]) && atoi_results_short && atoi_results_short <= 4094) + && atoi_short(cmd_words_b[2]) && atoi_results_short <= 4094) port_pvid_set(atoi_results_u8, atoi_results_short); else { - cmd_error("pvid <1-4094>\n"); + cmd_error("pvid <0-4094>\n"); } } else if (cmd_compare(0, "vlan")) { parse_vlan(); diff --git a/html/app.js b/html/app.js index e636ddbf..f781cfe1 100644 --- a/html/app.js +++ b/html/app.js @@ -1619,7 +1619,6 @@ function vlan2str(i, n, t, u) { function pvidcmd(i, p){ return "pvid " + p + " " + i; } -const parkingVLAN=4094; function mySplit(a){ if(a.trim()=="") return []; return a.trim().split(","); @@ -1674,7 +1673,7 @@ function vlanApply() { //park all ports with only tagged membership for (p in vlansPerPort){ if (vlansPerPort[p].u.length == 0 && vlansPerPort[p].t.length > 0) { - tail_cmds.push(pvidcmd(parkingVLAN, p)); + tail_cmds.push(pvidcmd(0, p)); } }