test: drop the unused typedef keyword and make the gcc-only warning switch conditional

Building the firmware headers on the host showed two warnings from
machine.h: `typedef struct machine { ... };` and the same for
machine_runtime declare no alias, so the keyword only draws "useless
storage class specifier in empty declaration". Every user says
`struct machine`, so drop the keyword.

-Wno-builtin-declaration-mismatch is a gcc switch and clang reports it
as an unknown option on every build; add it only when the compiler is
not clang.
This commit is contained in:
bloqaudio committed 2026-09-14 14:05:33 -05:00
1 parent dcd3cd5a98
commit c05d83132b
2 files changed
+6 -3

No files matched your search

+2 -2
View File
@@ -74,7 +74,7 @@ struct sfp_port
i2c_bus_t i2c; i2c_bus_t i2c;
}; };
typedef struct machine { struct machine {
char machine_name[30]; char machine_name[30];
uint8_t isRTL8373; uint8_t isRTL8373;
// Lowest logical port number // Lowest logical port number
@@ -102,7 +102,7 @@ typedef struct machine {
uint32_t mac_flash_offset; uint32_t mac_flash_offset;
}; };
typedef struct machine_runtime struct machine_runtime
{ {
uint8_t isRTL8373 : 1; uint8_t isRTL8373 : 1;
uint8_t isN : 1; uint8_t isN : 1;
+4 -1
View File
@@ -12,9 +12,12 @@ CC = gcc
SRCROOT = .. SRCROOT = ..
# -include shim first so __xdata/__code/__banked vanish before any firmware header. # -include shim first so __xdata/__code/__banked vanish before any firmware header.
CFLAGS = -std=gnu11 -g -O1 -Wall -Wextra -Wno-unused-parameter -Wno-unknown-pragmas \ CFLAGS = -std=gnu11 -g -O1 -Wall -Wextra -Wno-unused-parameter -Wno-unknown-pragmas \
-Wno-builtin-declaration-mismatch -DRTLP_HOST_TEST \ -DRTLP_HOST_TEST \
-fsanitize=address,undefined -fno-omit-frame-pointer \ -fsanitize=address,undefined -fno-omit-frame-pointer \
-include sdcc_shim.h -I. -I$(SRCROOT) -I$(SRCROOT)/httpd -I$(SRCROOT)/uip -include sdcc_shim.h -I. -I$(SRCROOT) -I$(SRCROOT)/httpd -I$(SRCROOT)/uip
ifeq ($(findstring clang,$(shell $(CC) --version 2>/dev/null)),)
CFLAGS += -Wno-builtin-declaration-mismatch
endif
LDFLAGS = -fsanitize=address,undefined LDFLAGS = -fsanitize=address,undefined
BUILDDIR = build BUILDDIR = build