cmd: add reg read and write.

like:
* `reg w 04`
* `reg w 04 00023678`

cmd_parser.c

@@ -25,6 +25,7 @@ extern __xdata uint8_t isRTL8373;
 extern __xdata uint16_t mpos;
 
 extern volatile __xdata uint32_t ticks;
+extern volatile __xdata uint8_t sfr_data[4];
 
 extern __code uint8_t * __code greeting;
 extern __code uint8_t * __code hex;
@@ -34,6 +35,10 @@ __xdata uint8_t vlan_names[VLAN_NAMES_SIZE];
 __xdata uint16_t vlan_ptr;
 __xdata uint8_t gpio_last_value[8] = { 0 };
 
+// Temporatly for str to hex convertion value.
+// Support up to 32_bits.
+__xdata uint8_t hexvalue[4] = { 0 };
+
 
 // Buffer for writing to flash 0x1fd000, copy to 0x1fe000
 __xdata uint8_t cmd_buffer[SBUF_SIZE];
@@ -80,6 +85,50 @@ uint8_t cmd_compare(uint8_t start, uint8_t * __code cmd)
 }
 
 
+/* Converts ascii-hex array into value.
+	returns number of hexvalue[] entries has been written.
+	return value = 0 means error.
+*/
+uint8_t atoi_hex(uint8_t idx)
+{
+	uint8_t h_idx = 0;
+	uint8_t val = 0;
+	uint8_t c;
+
+	while(1) {
+		c = cmd_buffer[idx];
+
+		if (c == '\0' || c == ' ') {
+			break;
+		}
+
+		// swap hex nibbles
+		val = (val >> 4) | (val << 4);
+
+		if (c - '0' < 10) {
+			val |= c - '0';
+		} else {
+			c |= 0x20;
+			c -= 'a';
+			if (c > 5) {
+				h_idx = 0;
+				break;
+			}
+			val |= c + 10;
+		}
+
+		idx++;
+		hexvalue[h_idx >> 1] = val;
+
+		if (h_idx & 1 == 1) {
+			val = 0;
+		}
+		h_idx++;
+	}
+
+	return ((h_idx + 1) >> 1);
+}
+
 uint8_t atoi_short(register uint16_t *vlan, register uint8_t idx)
 {
 	uint8_t err = 1;
@@ -251,6 +300,82 @@ void parse_mirror(void)
 }
 
 
+void parse_reg(void)
+{
+	__xdata uint16_t reg = 0;
+	uint8_t read = 0xFF;
+
+	if (cmd_words_b[2] < 0) {
+		write_char('v');
+		goto err;
+	}
+
+	if (cmd_buffer[cmd_words_b[1]] == 'w') {
+		write_char('w');
+		read = 0;
+	}
+
+	if (cmd_buffer[cmd_words_b[1]] == 'r') {
+		write_char('r');
+		read = 1;
+	}
+
+	if (read == 0xFF) {
+		print_string("usage: reg r <hexvalue> or reg w <hexvalue> <hexvalue>");
+		return;
+	}
+
+	uint8_t hex_size = atoi_hex(cmd_words_b[2]);
+
+	if (hex_size == 0 || hex_size > 2) {
+		write_char('s');
+		goto err;
+	}
+
+	if (hex_size == 1) {
+		reg = hexvalue[0];
+	} else {
+		reg = (((uint16_t)hexvalue[0]) << 8) | hexvalue[1];
+	}
+
+	print_string("REG: ");
+	print_short(reg);
+	print_string(": VAL: ");
+
+	if (read) {
+		reg_read_m(reg);
+
+	} else {
+		hex_size = atoi_hex(cmd_words_b[3]);
+
+		if (hex_size == 0 || hex_size > 4 || cmd_words_b[3] < 0) {
+			write_char('S');
+			goto err_write;
+		}
+
+		// zero sfp data
+		sfr_set_zero();
+
+		// copy data over
+		while(hex_size) {
+			hex_size -= 1;
+			sfr_data[hex_size] = hexvalue[hex_size];
+		}
+
+		reg_write_m(reg);
+	}
+	print_sfr_data();
+	write_char('\n');
+	return;
+
+err:
+	print_string("usage: reg r <hexvalue> like reg r 00BB");
+	return;
+err_write:
+	print_string("usage: reg w <hexvalue> <hexvalue> like reg e 00BB 00112233");
+}
+
+
 // Parse command into words
 uint8_t cmd_tokenize(void) __banked
 {
@@ -308,7 +433,6 @@ void print_gpio_status(void) {
 		print_byte( gpio_last_value[(idx *4) + 3] ^ SFR_DATA_0);
 		gpio_last_value[(idx *4) + 3] = SFR_DATA_0;
 		write_char('\n');
-		write_char('\n');
 	}
 }
 
@@ -453,10 +577,12 @@ void cmd_parser(void) __banked
 		if (cmd_compare(0, "sds")) {
 			print_reg(RTL837X_REG_SDS_MODES);
 		}
-
+		if (cmd_compare(0, "gpio")) {
-		if (cmd_compare(0, "gpio stat")) {
 			print_gpio_status();
 		}
+		if (cmd_compare(0, "reg")) {
+			parse_reg();
+		}
 	}
 }
 
@@ -478,3 +604,4 @@ void execute_config(void) __banked
 		}
 	} while (mpos != 0xffff);
 }
+

rtl837x_common.h

@@ -75,6 +75,7 @@ void print_reg(uint16_t reg);
 uint8_t sfp_read_reg(uint8_t slot, uint8_t reg);
 void reg_bit_set(uint16_t reg_addr, char bit);
 void reg_bit_clear(uint16_t reg_addr, char bit);
+void sfr_set_zero(void);
 void reset_chip(void);
 void memcpy(__xdata void * __xdata dst, __xdata const void * __xdata src, uint16_t len);
 void memcpyc(register __xdata uint8_t *dst, register __code uint8_t *src, register uint16_t len);

rtlplayground.c

@@ -61,6 +61,7 @@ __xdata uint8_t sbuf[SBUF_SIZE];
 __xdata uint8_t sfr_data[4];
 
 extern __xdata uint8_t cmd_buffer[SBUF_SIZE];
+extern __xdata uint8_t gpio_last_value[8];
 
 __code uint8_t * __code greeting = "\nA minimal prompt to explore the RTL8372:\n";
 __code uint8_t * __code hex = "0123456789abcdef";
@@ -380,6 +381,16 @@ void sfr_mask_data(uint8_t n, uint8_t mask, uint8_t set)
 	sfr_data[3-n] = b;
 }
 
+/*
+ * This zeros all the sfr data fields
+ */
+void sfr_set_zero(void) {
+	uint8_t idx = 4;
+	while (idx) {
+		idx -= 1;
+		sfr_data[idx] = 0;
+	}
+}
 
 /*
  * Transfer Network Interface RX data from the ASIC to the 8051 XMEM

rtlplayground.mem

@@ -25,5 +25,5 @@ Other memory:
    Name             Start    End      Size     Max     
    ---------------- -------- -------- -------- --------
    PAGED EXT. RAM                         0      256   
-   EXTERNAL RAM     0x0001   0x1ad8    6872    16777216
+   EXTERNAL RAM     0x0001   0x1aea    6890    16777216
-   ROM/EPROM/FLASH  0x0000   0x1c195  45278    16777216
+   ROM/EPROM/FLASH  0x0000   0x1c72c  47034    16777216