gitproxy/RTLPlayground
1
0
Fork 0
mirror of https://github.com/logicog/RTLPlayground.git synced 2026-08-30 14:52:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Flash: fix: Don't use READ 0x03 flash command.

Browse Source 
In commit 884bc18, `Fast Read 0x0b` was exchanged for `Read 0x03` command.
This was done because I did not see the difference between the commands
and the extra dummycycles looks like wasted time. But I overlooked that
many flash devices, the `Read 0x03` command can't run at the maximum
SPI-clock speed, but only half or less of the maximum SPI-clock speed.
This can cause in-transit data corruption while reading the device.

So change it back to `Fast Read 0x0b` command, so the SPI device is used
within the device specification.
This commit is contained in:
René van Dorst
2026-01-06 19:45:33 +01:00
parent 52832ff299
commit 745c170f0a
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rtl837x_flash.c
+5 -3
View File
@@ -16,7 +16,9 @@ __xdata struct flash_region_t flash_region;
// For the flash commands, see e.g. Windbond W25Q32JV datasheet // For the flash commands, see e.g. Windbond W25Q32JV datasheet
#define CMD_WRITE_STATUS 0x01 #define CMD_WRITE_STATUS 0x01
#define CMD_PAGE_PROGRAM 0x02 #define CMD_PAGE_PROGRAM 0x02
#define CMD_READ 0x03 // Don't use command `READ 0x03`, because on many device this command can't run at maximum SPI-clock speed.
// Use `Fast READ 0x0b` instead!
//#define CMD_READ 0x03
#define CMD_WRITE_ENABLE 0x06 #define CMD_WRITE_ENABLE 0x06
#define CMD_FREAD 0x0b #define CMD_FREAD 0x0b
#define CMD_SECTOR_ERASE 0x20 #define CMD_SECTOR_ERASE 0x20
@@ -249,8 +251,8 @@ void flash_read_bulk(__xdata uint8_t *dst)
SFR_FLASH_DUMMYCYCLES = 4; SFR_FLASH_DUMMYCYCLES = 4;
} else { } else {
SFR_FLASH_MODEB = 0x0; SFR_FLASH_MODEB = 0x0;
SFR_FLASH_CMD_R = CMD_READ; SFR_FLASH_CMD_R = CMD_FREAD; // Fast read
SFR_FLASH_DUMMYCYCLES = 0; SFR_FLASH_DUMMYCYCLES = 8; // Add 8 dummy clocks
} }