gitproxy/RTLPlayground
1
0
Fork 0
mirror of https://github.com/logicog/RTLPlayground.git synced 2026-08-30 14:52:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

port: reject the CPU port in isolate instead of refusing it silently

Browse Source 
parse_isolate() accepted a two digit port and mapped it to logical port 9,
the CPU port, while port_isolate() and port_isolation_get() both refuse
anything above machine.max_port. Setting the isolation of the CPU port was
therefore declined without a word and reading it always answered no
members, whatever the hardware held.

Bound the port to the front panel, so the command says what it does. The
digit is checked before it indexes phys_to_log_port[], which a non numeric
argument used to read past.
This commit is contained in:
d00f
2026-08-17 10:53:17 +02:00
parent 59d20ed9b6
commit 47b3ee60b6
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd_parser.c
+5 -5
View File
@@ -428,11 +428,11 @@ void parse_isolate(void)
print_string("\nISOLATE "); print_string("\nISOLATE ");
__xdata int8_t port_configured = cmd_buffer[cmd_words_b[1]] - '1'; if (!isnumber(cmd_buffer[cmd_words_b[1]]) || cmd_buffer[cmd_words_b[1]] == '0'
port_configured = machine.phys_to_log_port[port_configured]; || isnumber(cmd_buffer[cmd_words_b[1] + 1]))
if (isnumber(cmd_buffer[cmd_words_b[1] + 1])) // CPU-port, logical port 9 goto err;
port_configured = (port_configured + 1) * 10 + cmd_buffer[cmd_words_b[1] + 1] - '1'; __xdata uint8_t port_configured = machine.phys_to_log_port[cmd_buffer[cmd_words_b[1]] - '1'];
if (port_configured < 0 || port_configured > 9) if (port_configured < machine.min_port || port_configured > machine.max_port)
goto err; goto err;
print_byte(port_configured); write_char('\n'); print_byte(port_configured); write_char('\n');