From 3a924591901a92e33eda255fb43e7a80bab9d335 Mon Sep 17 00:00:00 2001 From: d00f <8052722+DrDoof@users.noreply.github.com> Date: Wed, 16 Sep 2026 01:56:42 +0200 Subject: [PATCH] build: don't regenerate html_data from the image rule The .bin rule passes -p html_data to fileadder, which rewrites html_data.c and html_data.h after the objects that include them have already been compiled and linked. The next make therefore rebuilds html_data.c, httpd.c and page_impl.c even when nothing changed, and so does the one after that. The rule only needs to embed the files into the image; the header comes from the html_data.c rule above. Spotted by plaes in #358, which cannot be merged as it stands. With this and the previous commit, a second make after a full build compiles nothing, and the image is byte for byte the same as before. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9a4a1236..aa1839c4 100644 --- a/Makefile +++ b/Makefile @@ -165,7 +165,7 @@ $(BUILDDIR)/rtlplayground-$(FILENAME_EXTENSION).bin: $(BUILDDIR)/rtlplayground.i tools/output/imagebuilder -i $^ $@ tools/output/fileadder -a $(DEFAULT_CONFIG_LOCATION) -s $(IMAGESIZE) -d config.txt $@ tools/output/fileadder -a $(CONFIG_LOCATION) -s $(IMAGESIZE) -d config.txt $@ - tools/output/fileadder -a $(HTML_LOCATION) -s $(IMAGESIZE) -z -d $(HTML_MIN) -p html_data -b BANK1 $@ + tools/output/fileadder -a $(HTML_LOCATION) -s $(IMAGESIZE) -z -d $(HTML_MIN) -b BANK1 $@ tools/output/crc_calculator -u $@ ln -sf $(MACHINE)/rtlplayground-$(FILENAME_EXTENSION).bin output/rtlplayground.bin