From 2fa4686b334f1d28bfa0f047296d2dfcac62865f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ren=C3=A9=20van=20Dorst?= <opensource@vdorst.com>
Date: Mon, 31 Aug 2026 21:00:37 +0200
Subject: [PATCH] fix review points.

---
 rtlplayground.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/rtlplayground.c b/rtlplayground.c
index dca7cfa..72d1e27 100644
--- a/rtlplayground.c
+++ b/rtlplayground.c
@@ -1830,13 +1830,15 @@ void init_smi(void)
 	// Default: 0x000000ff
 	// Workaround for SDCC BUG 4070: SFR_DATA_U32 = 0x000000ff;
 	SFR_DATA_U16_UPPER = 0x0000;
-	SFR_DATA_U16= 0x00ff;
+	SFR_DATA_U16 = 0x00ff;
 	if (!machine_detected.isRTL8373) {
 		if (machine.n_sfp == 2) {
+			// 0x000000f0, only change the bytes that differs from the default.
 			SFR_DATA_0 = 0xf0;
 		} else {
+			// 0x000001f8, only change the bytes that differs from the default.
+			SFR_DATA_8 = 0x01;
 			SFR_DATA_0 = 0xf8;
-			SFR_DATA_16 = 0x1f;
 		}
 	}
 	reg_write(RTL837X_REG_SMI_PORT_POLLING);