gitproxy/RTLPlayground
1
0 Fork 0
mirror of https://github.com/logicog/RTLPlayground.git synced 2026-10-29 17:54:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

boot/i2c-setup(): Remove the switch-statement defaults.

Browse Source 
All the possibilities are handled, or otherwise a compile-time macro
I2CBUS_VALID ensures invalid options are rejected with a compiler error.

Also fix a compiler warning.
This commit is contained in:
René van Dorst committed 2026-09-20 11:25:35 +02:00
1 parent 19ccc4003d
commit 131bc106af
1 file changed
+2 -6
Download Patch File Download Diff File Expand all files Collapse all files
boot.c
+2 -6
View File
@@ -398,10 +398,10 @@ void setup_i2c(void) __banked
reg_read_m(RTL837X_PIN_MUX_1); reg_read_m(RTL837X_PIN_MUX_1);
for (uint8_t sfp = 0; sfp < machine.n_sfp; sfp++) { for (uint8_t sfp = 0; sfp < machine.n_sfp; sfp++) {
uint8_t i2c = machine.sfp_port[sfp].i2c; uint8_t i2c = machine.sfp_port[sfp].i2c;
uint8_t scl_bus = (i2c >> RTL837X_REG_I2C_SCL_SHIFT) & 0x07; uint8_t scl_bus = (i2c >> RTL837X_REG_I2C_SCL_SHIFT);
uint8_t sda_bus = (i2c >> RTL837X_REG_I2C_SDA_SHIFT) & 0x07; uint8_t sda_bus = (i2c >> RTL837X_REG_I2C_SDA_SHIFT) & 0x07;
print_string("Configuring I2C for SFP idx="); print_byte(sfp); print_string(" SCL="); print_byte(scl_bus); print_string(", SDA="); print_byte(sda_bus); write_char('\n'); print_string("Configuring I2C for SFP idx="); print_byte(sfp); print_string(" SCL="); print_byte(scl_bus); print_string(", SDA="); print_byte(sda_bus); write_char('\n');
switch (scl_bus) { switch (scl_bus & 0x03) {
case 3: case 3:
// Bit 5-6 0b10 -> SCL (implies enabled SDA on bus 3) // Bit 5-6 0b10 -> SCL (implies enabled SDA on bus 3)
sfr_mask_data(0, 0x60, 0x40); sfr_mask_data(0, 0x60, 0x40);
@@ -420,8 +420,6 @@ void setup_i2c(void) __banked
sfr_mask_data(0, 0x80, 0x80); sfr_mask_data(0, 0x80, 0x80);
sfr_mask_data(1, 0x01, 0x00); sfr_mask_data(1, 0x01, 0x00);
break; break;
default:
print_string("Invalid SCL bus number: "); print_byte(scl_bus); write_char('\n');
} }
switch (sda_bus) { switch (sda_bus) {
@@ -445,8 +443,6 @@ void setup_i2c(void) __banked
// Bit 9-10 0b01 -> SDA // Bit 9-10 0b01 -> SDA
sfr_mask_data(1, 0x06, 0x02); sfr_mask_data(1, 0x06, 0x02);
break; break;
default:
print_string("Invalid SDA bus number: "); print_byte(sda_bus); write_char('\n');
} }
} }
reg_write_m(RTL837X_PIN_MUX_1); reg_write_m(RTL837X_PIN_MUX_1);