From 265a80bb255c9c5a3c333a6a0b6d6abc5471291a Mon Sep 17 00:00:00 2001 From: Rob Emery Date: Mon, 12 Oct 2026 20:32:29 +0100 Subject: [PATCH 1/2] Trapping the 01:80:c2:00:00:0e prevents the switch from passing between ports --- cmd_parser.c | 3 +++ rtl837x_regs.h | 1 + 2 files changed, 4 insertions(+) diff --git a/cmd_parser.c b/cmd_parser.c index e7daa9e8..202fd923 100644 --- a/cmd_parser.c +++ b/cmd_parser.c @@ -18,6 +18,7 @@ #include "rtl837x_bandwidth.h" #include "rtl837x_lldp.h" #include "rtl837x_storm.h" +#include "rtl837x_trap.h" #include "sfp.h" #include "dhcp.h" #include "syslog.h" @@ -2043,9 +2044,11 @@ void cmd_parser(void) __banked if (cmd_compare(1, "on")) { print_string("LLDP enabled\n"); lldp_enabled = 1; + trap_rma_set(RTL837X_RMA0_CONF_0E, RTL837X_RMA_ACT_TRAP); } else { print_string("LLDP disabled\n"); lldp_enabled = 0; + trap_rma_set(RTL837X_RMA0_CONF_0E, RTL837X_RMA_ACT_FORWARD); } } else { diff --git a/rtl837x_regs.h b/rtl837x_regs.h index dc4b2dc1..7730e85f 100644 --- a/rtl837x_regs.h +++ b/rtl837x_regs.h @@ -285,6 +285,7 @@ */ #define RTL8373_RLDP_TIMER 0x1074 #define RTL837X_RMA0_CONF 0x4ecc +#define RTL837X_RMA0_CONF_0E 0x4ee8 #define RTL837X_RMA2_CONF 0x4ed4 #define RTL837X_RMA_ACT_MASK 0x30 #define RTL837X_RMA_ACT_FORWARD 0x00 From e4adec9c1106af9d5b0898056631e46bfff4f300 Mon Sep 17 00:00:00 2001 From: Rob Emery Date: Tue, 13 Oct 2026 08:27:53 +0100 Subject: [PATCH 2/2] Renaming for consistency and spaces -> tabs --- cmd_parser.c | 4 ++-- rtl837x_regs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd_parser.c b/cmd_parser.c index 202fd923..1cd128b5 100644 --- a/cmd_parser.c +++ b/cmd_parser.c @@ -2044,11 +2044,11 @@ void cmd_parser(void) __banked if (cmd_compare(1, "on")) { print_string("LLDP enabled\n"); lldp_enabled = 1; - trap_rma_set(RTL837X_RMA0_CONF_0E, RTL837X_RMA_ACT_TRAP); + trap_rma_set(RTL837X_RMA0E_CONF, RTL837X_RMA_ACT_TRAP); } else { print_string("LLDP disabled\n"); lldp_enabled = 0; - trap_rma_set(RTL837X_RMA0_CONF_0E, RTL837X_RMA_ACT_FORWARD); + trap_rma_set(RTL837X_RMA0E_CONF, RTL837X_RMA_ACT_FORWARD); } } else { diff --git a/rtl837x_regs.h b/rtl837x_regs.h index 7730e85f..c2117fb1 100644 --- a/rtl837x_regs.h +++ b/rtl837x_regs.h @@ -285,7 +285,7 @@ */ #define RTL8373_RLDP_TIMER 0x1074 #define RTL837X_RMA0_CONF 0x4ecc -#define RTL837X_RMA0_CONF_0E 0x4ee8 +#define RTL837X_RMA0E_CONF 0x4ee8 #define RTL837X_RMA2_CONF 0x4ed4 #define RTL837X_RMA_ACT_MASK 0x30 #define RTL837X_RMA_ACT_FORWARD 0x00